Add iterate for Reverse{<:NamedTuple} #43038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the problem mentioned in JuliaLang#42991 (comment)
bkamins
commented
Nov 11, 2021
|
Also relatedly I would propose to come back to #16604 (comment) PR and make a decision. |
bkamins
commented
Nov 11, 2021
|
Maybe we could consider making this a good default definition too? |
This would assume that by default the iterator supports 1-based indexing. |
|
@JeffBezanson - is this good to merge? Independent of the other discussions about handling of |
oscardssmith
approved these changes
Nov 13, 2021
DilumAluthge
removed
the
merge me
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Fixes the problem mentioned in JuliaLang#42991 (comment)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Fixes the problem mentioned in JuliaLang#42991 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem mentioned in #42991 (comment)