sparse: Optimize swaprows!, swapcols! #42678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a swpacols! helper in Base that is used in the permuation code as well as in the bareiss factorization code. I was working on extending the latter, among others to sparse arrays and alternative pivot choices. To that end, this PR, adds swaprows! in analogy with swapcols! and adds optimized implementations for SparseMatrixCSC. Note that neither of these functions are currently exported (though since they are useful, we may want a generic swapslices! of some sort, but that's for a future PR). While we're at it, also replace the open-coded in-place circshift! by one on SubArray, such that they can automatically beneift if that method is optimized in the future (#42676).
andreasnoack
approved these changes
Oct 18, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
We have a swpacols! helper in Base that is used in the permuation code as well as in the bareiss factorization code. I was working on extending the latter, among others to sparse arrays and alternative pivot choices. To that end, this PR, adds swaprows! in analogy with swapcols! and adds optimized implementations for SparseMatrixCSC. Note that neither of these functions are currently exported (though since they are useful, we may want a generic swapslices! of some sort, but that's for a future PR). While we're at it, also replace the open-coded in-place circshift! by one on SubArray, such that they can automatically beneift if that method is optimized in the future (JuliaLang#42676).
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
We have a swpacols! helper in Base that is used in the permuation code as well as in the bareiss factorization code. I was working on extending the latter, among others to sparse arrays and alternative pivot choices. To that end, this PR, adds swaprows! in analogy with swapcols! and adds optimized implementations for SparseMatrixCSC. Note that neither of these functions are currently exported (though since they are useful, we may want a generic swapslices! of some sort, but that's for a future PR). While we're at it, also replace the open-coded in-place circshift! by one on SubArray, such that they can automatically beneift if that method is optimized in the future (JuliaLang#42676).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a swpacols! helper in Base that is used in the permuation
code as well as in the bareiss factorization code. I was working
on extending the latter, among others to sparse arrays and
alternative pivot choices. To that end, this PR, adds swaprows!
in analogy with swapcols! and adds optimized implementations for
SparseMatrixCSC. Note that neither of these functions are currently
exported (though since they are useful, we may want a generic
swapslices! of some sort, but that's for a future PR).
While we're at it, also replace the open-coded in-place circshift!
by one on SubArray, such that they can automatically beneift
if that method is optimized in the future (#42676).
cc also @abraunst who implemented sparse circshift!