Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in docstring of repeat #36376

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

kimikage
Copy link
Contributor

@kimikage kimikage commented Jun 21, 2020

This changes the link targets of ^ parseable and more specific.

This fixes the problem in the first half of #35693 (comment). These four seem like a problem with Documenter.jl (cf. JuliaDocs/Documenter.jl#505) (or Julia).

Edit:
The ^ without signatures should refer to
base/math/#Base.:^-Tuple{Number,Number}
but in "base/foo.md", the relative URL is resolved into:
../math/#Base.:^-Tuple{Number,Number} in "base/punctuation.md",
math/#Base.:^-Tuple{Number,Number} in "base/arrays.md".

In any case, the math/#Base.:^ is not a suitable reference for ^ in the docstring of repeat. This is the reason for fixing only the first half.

This changes the link targets of `^` parseable and more specific.
@kimikage kimikage marked this pull request as ready for review June 21, 2020 18:55
@dkarrasch dkarrasch added the docs This change adds or pertains to documentation label Jun 22, 2020
@JeffBezanson JeffBezanson merged commit 0a661f9 into JuliaLang:master Jun 25, 2020
@kimikage
Copy link
Contributor Author

kimikage commented Jun 26, 2020

I'm sorry, but the problem doesn't seem to be totally fixed by this. Probably, we should remove the duplicated docs for repeat in "base/arrays".

cc: @mortenpi

@kimikage kimikage deleted the docs-repeat branch June 26, 2020 02:25
mbauman added a commit to dlfivefifty/julia that referenced this pull request Jun 26, 2020
* origin/master: (232 commits)
  Add passthrough for non-Markdown docs (JuliaLang#36091)
  Fix pointer to no longer assume contiguity (JuliaLang#36405)
  Ensure string-hashing is defined before it gets used (JuliaLang#36411)
  Make compilecache atomic (JuliaLang#36416)
  add a test for JuliaLang#30739 (JuliaLang#36395)
  Fix broken links in docstring of `repeat` (JuliaLang#36376)
  fix and de-dup cached calls to `methods_by_ftype` in compiler (JuliaLang#36404)
  ml-matches: skip unnecessary work, when possible (JuliaLang#36413)
  gf: fix some issues with the move from using a tree to a hash lookup of leaf types (JuliaLang#36413)
  Add news and manual entry for sincospi (JuliaLang#36403)
  Check axes in Array(::AbstractArray) (fixes JuliaLang#36220) (JuliaLang#36397)
  add versions of `code_typed` and `which` that accept tuple types (JuliaLang#36389)
  Fix spelling of readdir. (JuliaLang#36409)
  add sincospi (JuliaLang#35816)
  fix showing methods with unicode gensymed variable names (JuliaLang#36396)
  Add doctest: eachslice (JuliaLang#36386)
  fix documentation typo ("Ingeger")
  Refactor `abstract_eval` to separate out statements and values (JuliaLang#36350)
  fix return type of `get!` on `IdDict` (JuliaLang#36383)
  Allow single option with REPL.TerminalMenus (JuliaLang#36369)
  ...
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
This changes the link targets of `^` parseable and more specific.
m0ch1m0ch1 referenced this pull request in fms-lab/julia-doc-ja Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants