fix generic ldiv! for CholeskyPivoted #32593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
approved these changes
Jul 20, 2019
|
Are we going to backport this? If yes, then I probably shouldn't interweave the two tests (i.e., this one with #32594), should I? |
|
I've added backport labels and I think you are right that it would be easier if you don't join them. |
|
Is this ready to go? |
|
I think so, yes. The test changes are hopefully "minimally invasive" now, so this can be backported with reasonable effort. |
JeffBezanson
pushed a commit
that referenced
this pull request
Aug 5, 2019
* fix generic ldiv! for CholeskyPivoted * add back one empty line to make backport easier * don't interfere with previous tests (cherry picked from commit d0e11cf)
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
* fix generic ldiv! for CholeskyPivoted * add back one empty line to make backport easier * don't interfere with previous tests (cherry picked from commit d0e11cf)
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
* fix generic ldiv! for CholeskyPivoted * add back one empty line to make backport easier * don't interfere with previous tests (cherry picked from commit d0e11cf)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
* fix generic ldiv! for CholeskyPivoted * add back one empty line to make backport easier * don't interfere with previous tests (cherry picked from commit d0e11cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to implement an
rdiv!for Cholesky, and started by adopting the genericldiv!, since I don't know how to do it with LAPACK. I realized that the code was returning the correct result, but was not overwriting the input as one would expect. Corresponding permutation code, however, was included in the LAPACK-versions ofldiv!. This PR fixes this.