Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Store UnicodeData.txt within $(SRCCACHE)" #31500

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Revert "Store UnicodeData.txt within $(SRCCACHE)" #31500

merged 1 commit into from
Mar 27, 2019

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Mar 27, 2019

Reverts #31476 (while we fix it)

@vtjnash vtjnash requested a review from staticfloat March 27, 2019 17:09
@staticfloat
Copy link
Member

Whoops, you're right.

@staticfloat staticfloat merged commit 025f620 into master Mar 27, 2019
@staticfloat
Copy link
Member

The reason I didn't notice this (and the buildbots didn't care) is because all my systems always override SRCCACHE from the global level.

@vtjnash vtjnash deleted the revert-31476-sf/srccache_unicodedata branch March 27, 2019 19:34
@vtjnash
Copy link
Member Author

vtjnash commented Mar 27, 2019

We can probably still do this, we should just have deps do the download and put the file somewhere predictable for us.

@staticfloat
Copy link
Member

I have a second PR up (that I requested your review on) that just initializes SRCCACHE in the same way that deps/Makefile does.

@KristofferC KristofferC mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtjnash @staticfloat