Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev-doc updates for the SSAIR section #30622

Merged
merged 2 commits into from
Jan 18, 2020
Merged

Dev-doc updates for the SSAIR section #30622

merged 2 commits into from
Jan 18, 2020

Conversation

tshort
Copy link
Contributor

@tshort tshort commented Jan 7, 2019

This mainly fixes typos.

Note that I think the foo function on line 114 is wrong. It errors when run (y not defined), and it doesn't match the IR shown below it (there's no bar function for example). I don't have a fix for that.

@ViralBShah ViralBShah added the docs This change adds or pertains to documentation label Jan 7, 2019
@fredrikekre fredrikekre requested a review from Keno January 7, 2019 09:50
@StefanKarpinski StefanKarpinski requested review from Keno and removed request for Keno January 7, 2019 14:07
@KristofferC KristofferC mentioned this pull request Jan 11, 2019
53 tasks
@StefanKarpinski StefanKarpinski added backport 1.1 triage This should be discussed on a triage call and removed backport 1.1 labels Jan 31, 2019
@StefanKarpinski
Copy link
Member

Bump.

@StefanKarpinski StefanKarpinski removed triage This should be discussed on a triage call backport 1.1 labels Apr 11, 2019
@StefanKarpinski
Copy link
Member

No need to triage and we don't backport docs.

tshort and others added 2 commits January 17, 2020 17:44
This mainly fixes typos. 

Note that I think the `foo` function on line 114 is wrong. It errors when run (`y` not defined), and it doesn't match the IR shown below it (there's no `bar` function for example). I don't have a fix for that.
@Keno Keno merged commit ca5642d into JuliaLang:master Jan 18, 2020
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
* Dev-doc updates for the SSAIR section

This mainly fixes typos. 

Note that I think the `foo` function on line 114 is wrong. It errors when run (`y` not defined), and it doesn't match the IR shown below it (there's no `bar` function for example). I don't have a fix for that.

* Fix foo example

Co-authored-by: Keno Fischer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants