Put boxed arguments in llvmcall into the correct addrspace #30085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect Cxx is the only user at the moment, but absent this you either get an incorrect assert in debug builds (if you're setting addrspaces correctly in the called function), or missing GC roots (if you don't, to avoid the assert). Fix that.
|
Any chance of a test? |
Keno
force-pushed
the
kf/llvmcallboxed
branch
from
5f14ee0 to
c6783c9
Compare
vchuravy
approved these changes
Nov 20, 2018
Keno
force-pushed
the
kf/llvmcallboxed
branch
2 times, most recently
from
0936ae9 to
8a96e7b
Compare
Keno
force-pushed
the
kf/llvmcallboxed
branch
from
6593181 to
9049873
Compare
KristofferC
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect Cxx is the only user at the moment, but absent this
you either get an incorrect assert in debug builds (if you're
setting addrspaces correctly in the called function), or missing
GC roots (if you don't, to avoid the assert). Fix that.