Fix RoundNearestTiesAway #29700
Merged
Fix RoundNearestTiesAway #29700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2018
|
Note that this won't set the floating point status flags correctly. |
| y = floor(x) | ||
| ifelse(x==y,y,copysign(floor(2*x-y),x)) | ||
| function round(x::T, ::RoundingMode{:NearestTiesUp}) where {T <: AbstractFloat} | ||
| copysign(floor((x + (T(0.25) - eps(T(0.5)))) + (T(0.25) + eps(T(0.5)))), x) |
There was a problem hiding this comment.
Would prevfloat and nextfloat be clearer here?
There was a problem hiding this comment.
Perhaps: it would be
copysign(floor((x + prevfloat(T(0.25),4)) + nextfloat(T(0.25),2), x)
simonbyrne
force-pushed
the
sb/roundnearesttiesup
branch
from
d9ab4d6 to
07449a6
Compare
simonbyrne
force-pushed
the
sb/roundnearesttiesup
branch
from
07449a6 to
0d0834c
Compare
|
Backportable? |
tkf
pushed a commit
to tkf/julia
that referenced
this pull request
Nov 21, 2018
KristofferC
pushed a commit
that referenced
this pull request
Nov 28, 2018
KristofferC
pushed a commit
that referenced
this pull request
Dec 12, 2018
KristofferC
added
bugfix
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29698. Idea thanks to @raphlinus (https://twitter.com/raphlinus/status/1052646958962159616).