Adjust initialization in maximum and minimum (version 2) #28116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximum of OffsetArray example
|
Maybe add a test for #27992, too? |
I've just added that. |
KristofferC
reviewed
Jul 14, 2018
test/reducedim.jl
Outdated
| @test maximum(abs, Areduc, dims=region) ≈ safe_maxabs(Areduc, region) | ||
| @test minimum(abs, Areduc, dims=region) ≈ safe_minabs(Areduc, region) | ||
| @test @inferred sum(Areduc, dims=region) ≈ safe_sum(Areduc, region) | ||
| @test @inferred prod(Areduc, dims=region) ≈ safe_prod(Areduc, region) |
There was a problem hiding this comment.
Does this @inferred apply to the approx operator or the LHS?
There was a problem hiding this comment.
I guess it applies to the isapprox:
julia> f(x) = x < 0 ? '1' : 1
f (generic function with 1 method)
julia> using Test
julia> @inferred f(1)
ERROR: return type Int64 does not match inferred return type Union{Char, Int64}
Stacktrace:
[1] error(::String) at ./error.jl:33
[2] top-level scope at none:0
julia> @inferred f(1) == 1
true
julia> @inferred(f(1)) == 1
ERROR: return type Int64 does not match inferred return type Union{Char, Int64}
Stacktrace:
[1] error(::String) at ./error.jl:33
[2] top-level scope at none:0
nalimilan
reviewed
Jul 14, 2018
base/abstractarray.jl
Outdated
| # dimensions. When adding adding the dimensions, we have to respect the | ||
| # index type of the input array (e.g. in the case of OffsetArrays) | ||
| tmp = similar(Aslice, typeof(r1), reduced_indices(Aslice, 1:ndims(Aslice))) | ||
| tmp[first(CartesianIndices(tmp))] = r1 |
There was a problem hiding this comment.
firstindex(tmp) would work too, right?
Typo above: "adding adding".
andreasnoack
force-pushed
the
anj/reducediminit
branch
from
76d4af0 to
38419ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #27845 and #28101 (comment)