Added sortperm! #8792
Merged
Added sortperm! #8792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows preallocation (and therefore, reuse) of an index array * Useful for #8316
|
This makes me very happy. Thanks, Kevin! |
|
This is so awesome! I think |
|
Very nice. |
| @@ -341,6 +342,14 @@ sortperm(v::AbstractVector; alg::Algorithm=DEFAULT_UNSTABLE, | |||
| lt::Function=isless, by::Function=identity, rev::Bool=false, order::Ordering=Forward) = | |||
| sort!([1:length(v)], alg, Perm(ord(lt,by,rev,order),v)) | |||
|
|
|||
| function sortperm!{I<:Integer}(x::Vector{I}, v::AbstractVector; alg::Algorithm=DEFAULT_UNSTABLE, | |||
There was a problem hiding this comment.
I guess x can be an AbstractVector. Any reason it should not?
There was a problem hiding this comment.
Yeah, I think that should be fine. I actually started with that, and then changed it for some reason that I forget.
|
What about workspace allocation in the various sort algorithms? Presumably MergeSort has a workspace. Can we make that reusable by passing a work array too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One change which I'm unsure of here is loosening the types allowed for
lt(p::Perm, a, b)fromInttoInteger. I did it with the idea that, if a user is providing a preallocated array, she could choose to use a different integer type (e.g., a largeInt32array might have better cache performance thanInt64).That said, restricting the
sortpermarray type toVector{Int}would be fine as well. Thoughts?Cc: @ViralBShah, @StefanKarpinski