Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch tries to make reductions, especially
sum
andprod
, as type-stable as is feasible (#6069). Key strategies:v = op(A[1], A[2])
rather than asv = A[1]
.zero(T)+zero(T)
ifT
is known, rather thanzero(T)
. (Similarly forprod
andone
.)A[1] + zero(A[1])
rather thanA[1]
. (Similarly forprod
andone
.)sum
andprod
of empty collections for which the eltype is unknown now throw an exception rather than returning0
(which is the wrong answer for non-Number
collections).cc: @jiahao, @lindahua, @StefanKarpinski