Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: make isempty(itr) work for general iterables #5827

Merged
merged 1 commit into from
Feb 16, 2014

Conversation

stevengj
Copy link
Member

As mentioned in #5797, it would be nice if isempty(itr) worked for general iterable collections. The patch to implement this is trivial, and I don't see a downside to this.

@StefanKarpinski
Copy link
Member

I like it. Can't see any drawback to this. It also probably obviates a lot of more specific definitions which are probably equivalent to this general criterion.

@StefanKarpinski
Copy link
Member

I mean computationally equivalent.

@JeffBezanson
Copy link
Member

In fact it is identical to the definition of isempty for String.

JeffBezanson added a commit that referenced this pull request Feb 16, 2014
RFC: make isempty(itr) work for general iterables
@JeffBezanson JeffBezanson merged commit e924901 into JuliaLang:master Feb 16, 2014
stevengj added a commit that referenced this pull request Feb 16, 2014
@toivoh
Copy link
Contributor

toivoh commented Feb 17, 2014

+1

On Sun, Feb 16, 2014 at 1:02 AM, Steven G. Johnson <[email protected]

wrote:

As mentioned in #5797 #5797,
it would be nice if isempty(itr) worked for general iterable collections.

The patch to implement this is trivial, and I don't see a downside to this.

You can merge this Pull Request by running

git pull https://github.com/stevengj/julia isempty

Or view, comment on, or merge it at:

#5827
Commit Summary

File Changes

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com//pull/5827
.

@pao
Copy link
Member

pao commented Feb 17, 2014

@toivoh Already merged!

@toivoh
Copy link
Contributor

toivoh commented Feb 17, 2014

Ah, just saw it.

On Mon, Feb 17, 2014 at 9:25 PM, pao [email protected] wrote:

@toivoh https://github.com/toivoh Already merged!

Reply to this email directly or view it on GitHubhttps://github.com//pull/5827#issuecomment-35319621
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants