Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ccall signature for _include_from_serialized #57459

Open
vtjnash opened this issue Feb 18, 2025 · 0 comments
Open

Incorrect ccall signature for _include_from_serialized #57459

vtjnash opened this issue Feb 18, 2025 · 0 comments
Labels
ci Continuous integration regression 1.12 Regression in the 1.12 release

Comments

@vtjnash
Copy link
Member

vtjnash commented Feb 18, 2025

Bug appears to have been introduced by #56499. I don't know why this changed the ccall type in the middle of the other changes, but it introduced unsoundness here and triggers observable errors in CI:

      From worker 2:	ERROR: TypeError: in _svec_ref, expected Core.SimpleVector, got a value of type ErrorException
2025-02-17 17:49:27 EST	      From worker 2:	Stacktrace:
2025-02-17 17:49:27 EST	      From worker 2:	  [1] getindex
2025-02-17 17:49:27 EST	      From worker 2:	    @ ./essentials.jl:933 [inlined]
2025-02-17 17:49:27 EST	      From worker 2:	  [2] _include_from_serialized(pkg::Base.PkgId, path::String, ocachepath::String, depmods::Vector{Any}, ignore_native::Nothing; register::Bool)
2025-02-17 17:49:27 EST	      From worker 2:	    @ Base ./loading.jl:1294
2025-02-17 17:49:27 EST	      From worker 2:	  [3] _include_from_serialized (repeats 2 times)
2025-02-17 17:49:27 EST	      From worker 2:	    @ ./loading.jl:1246 [inlined]
2025-02-17 17:49:27 EST	      From worker 2:	  [4] _require_search_from_serialized(pkg::Base.PkgId, sourcepath::String, build_id::UInt128, stalecheck::Bool; reasons::Dict{String, Int64}, DEPOT_PATH::Vector{String})

https://buildkite.com/julialang/julia-master/builds/44900#019515d0-b7af-488d-bcb4-ae04e63e8459

@vtjnash vtjnash added regression 1.12 Regression in the 1.12 release ci Continuous integration labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration regression 1.12 Regression in the 1.12 release
Projects
None yet
Development

No branches or pull requests

1 participant