RFC: add pointer(s::Union(ByteString,UTF16String,UTF32String)) #5703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
pointer(s)
fors::Union(ByteString,UTF16String,UTF32String)
and substrings thereof. Not only is this more convenient thanconvert(Ptr{Foo}, s)
(becauses
knows the correct pointer type), but it also works for arbitrary substrings (whereasconvert
throws an error if the substring is not at the end).The patch also changes the
chars
field ofUTF32String
todata
for consistency with our other string types; this makes it easier to write methods that work onUnion(ByteString,UTF16String,UTF32String)
.Also, I changed the signature in
pointer{T}(x::AbstractArray{T}, i::Int)
topointer{T}(x::AbstractArray{T}, i::Integer)
, since I couldn't see any reason to restrict the index toInt
here.