-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Cartesian housekeeping, plus implementation of copy! #5671
Conversation
Good! I'll rebase my branch as soon as this is in. I thought this change would have allowed getting rid of things like these:
|
It does, I just missed them---they were just hard to see, since they were in the top 6 lines of the file 😄. Thanks! (If you see any more, don't hesitate to ask, or to fix when you submit your changes.) Fixed and rebased. Hmm, the original commits are still showing up on this page, but my git history for this branch doesn't show them---anyone know what's going on? Does github now keep copies of old commits when you do a forced update? |
Ah, now magically github seems to have gotten this straightened out. |
This allows the type of `size(S::SubArray)` to be inferred.
This allows one to pass additional "pre" arguments
…ons with a splatted argument
More Cartesian housekeeping, plus implementation of copy!
All yours, @carlobaldassi! |
@ngenerate
to add return-type annotation@nsplat
to generate specialized versions of functions that avoid splattingcopy!
for faster performance on SubArraysThe addition of
@nsplat
is not strictly necessary; I could ditch that and write them out by hand, if desired. The main motivation for adding it was to automatically synchronize the use of splatting with changes in CARTESIAN_DIMS.Performance gain on
copy!
is the usual:Master:
This branch:
CC @carlobaldassi.