SharedArray - take 2 #5380
Merged
SharedArray - take 2 #5380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good idea to break up the functionality into smaller pieces. |
|
This should be good to merge? |
|
Looks great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplified version of #4939
It only introduces a basic SharedArray. The intention is to get a basic implementation merged and then evolve it from there based on how folks end up using it.
I have deliberately left out exporting convenience constructors like
shmem_fillandshmem_rand, since these will probably evolve differently based on a consensus on how we are going to useArrayDistand the like as per the ongoing discussion in #4939