Deprecate cholpfact and qrpfact and introduce keyword arguments for pivoting. Make thin a keyword argument. #5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang build passed here. Rebasing #4621 was a real nightmare - redoing is certainly less error prone! |
|
Looks good. Let's merge it whenever you are ready. |
…ivoting. Make thin a keyword argument.
andreasnoack
added a commit
that referenced
this pull request
Jan 9, 2014
Deprecate cholpfact and qrpfact and introduce keyword arguments for pivoting. Make thin a keyword argument.
|
You're my hero. |
| @@ -111,6 +111,7 @@ export | |||
| svdvals!, | |||
| svdvals, | |||
| symmetrize!, | |||
| symmetrize_conj!, | |||
There was a problem hiding this comment.
Can we call this csymmetrize! instead? By analogy to ctranspose!?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to give up on rebasing #4621 and have tried to redo @jiahao's work here.