Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print a warning after using Foo: bar if bar is not public API #52553

Closed
CameronBieganek opened this issue Dec 15, 2023 · 1 comment
Closed

Print a warning after using Foo: bar if bar is not public API #52553

CameronBieganek opened this issue Dec 15, 2023 · 1 comment
Labels
duplicate Indicates similar issues or pull requests

Comments

@CameronBieganek
Copy link
Contributor

Now that #50105 has been merged, can we print a warning after using Foo: bar if bar is not marked with either export or public? Is adding a warning where there was none before considered a breaking change?

Having a warning would address one of the concerns in #42080, which is that encouraging using Foo: bar is likely to lead to folks bringing internal names into scope.
@CameronBieganek CameronBieganek mentioned this issue Dec 15, 2023
Merged
@KristofferC
Copy link
Member

Discussion here can probably be folded into #52314.

@LilithHafner LilithHafner closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
@LilithHafner LilithHafner added the duplicate Indicates similar issues or pull requests label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Indicates similar issues or pull requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KristofferC @CameronBieganek @LilithHafner