-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export tuple type length function #36820
Comments
This was originally proposed as a fast implementation for |
Can I work in this issue? Please guide me with the required procedures. I am new to this organisation. @NHDaly |
@vtjnash - what do you say? Do you have a preference on any of the names proposed above? ❤️ It would be great to allow @Kahanikaar to pick this up :) |
@Kahanikaar - Thanks for offering to help! Welcome to the community! 😁 That said, if you want to give this a shot and open a PR, we can always work-shop the name in the PR! I think resolving this issue would involve starting from this function: Lines 17 to 20 in 11cbaf6
and renaming it to one of the above choices, and then adding a nice docstring to it! :) We might also want to add it to the And finally depending on if there are already people relying on the existing name, Let me know if you have questions! |
Closing this, as |
Originally posted by @NHDaly in #32427 (comment)
#32427 added an unexported function,
_counttuple(::Type{<:Tuple})
which returns the number of elements in the tuple type.Can we name this something not private and export it? This is something we use all the time in our code at RelationalAI, where we do a lot of stuff with tuples. It also seems like something that other code will use a lot, like DataFrames, CSV, etc.
In that other comment I suggested
arity(::Type{<:Tuple})
as one suggestion. I still like that best, but open to others!arity()
tupletypewidth()
/tuple_type_width()
tupletypecount()
/tuple_type_count()
tuplearity()
tupletypelength()
/tuple_type_length()
The text was updated successfully, but these errors were encountered: