Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readdlm improvements #3468

Merged
merged 1 commit into from
Jun 21, 2013
Merged

readdlm improvements #3468

merged 1 commit into from
Jun 21, 2013

Conversation

tanmaykm
Copy link
Member

Used mmap to read files.

readdlm and readcsv now take optional named arguments to:

  • not use mmap
  • read header (and return a tuple: (data, hdr))
  • ignore invalid characters

In the process, introduced convert variants for creating ASCIIString and UTF8String from byte arrays while replacing invalid character sequences with a new (potentially empty) sequence.

@tanmaykm
readdlm improvements: use mmap by default. options to read header and…
f724a02 
… ignore invalid characters

added tests
fixed travis tests
tanmaykm added a commit that referenced this pull request Jun 21, 2013
@tanmaykm
Merge pull request #3468 from tanmaykm/readcsv
40e771a 
readdlm improvements
@tanmaykm tanmaykm merged commit 40e771a into JuliaLang:master Jun 21, 2013
@ViralBShah
Copy link
Member

Thanks - really useful to be able to ignore the invalid UTF-8 characters.

@stevengj stevengj mentioned this pull request Jun 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanmaykm @ViralBShah