Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARMv7]: bad instruction br r2 #29710

Closed
staticfloat opened this issue Oct 18, 2018 · 3 comments
Closed

[ARMv7]: bad instruction br r2 #29710

staticfloat opened this issue Oct 18, 2018 · 3 comments
Labels
building Build system, or building Julia or its dependencies system:arm ARMv7 and AArch64

Comments

@staticfloat
Copy link
Sponsor Member

The recently-resurrected ARMv7 buildbot is failing with the following error while compiling src/task.c:

{standard input}: Assembler messages:
{standard input}:133: Error: bad instruction `br r2'

Example error log: https://build.julialang.org/#/builders/5/builds/6/steps/4/logs/stdio

@staticfloat staticfloat added building Build system, or building Julia or its dependencies system:arm ARMv7 and AArch64 labels Oct 18, 2018
@staticfloat staticfloat changed the title [ARMv7]: bad instruction `br r2' [ARMv7]: bad instruction br r2 Oct 18, 2018
@yuyichao
Copy link
Contributor

https://github.com/JuliaLang/julia/blame/5f2759d85eeeb9c68e35e5e84b10715a49f4449d/src/task.c#L730 needs to be bx. Introduced in #13099. I don't know why it was changed from b start_task though, since the latter should be one instruction shorter...

@staticfloat
Copy link
Sponsor Member Author

I've changed it from br to bx on this branch, but reading the ARM docs on b vs. bx makes me think that you are correct; we should be able to just use b instead of bx here, since I don't think we should ever be in thumb mode. @vtjnash do you have any insight to share?

@vtjnash
Copy link
Sponsor Member

vtjnash commented Dec 3, 2018

I thought it was supposed to be common with AARCH64, I guess not, and should just use b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies system:arm ARMv7 and AArch64
Projects
None yet
Development

No branches or pull requests

3 participants