Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidiagonal times Triangular matrix multiplication fails #28493

Closed
mcognetta opened this issue Aug 7, 2018 · 1 comment
Closed

Bidiagonal times Triangular matrix multiplication fails #28493

mcognetta opened this issue Aug 7, 2018 · 1 comment
Labels
linear algebra Linear algebra

Comments

@mcognetta
Copy link
Contributor

Multiplying a bidiagonal matrix times a triangular matrix fails as there is no matching rmul method.

MWE:

julia> A = Bidiagonal(rand(10, 10), :U)
julia> B = UpperTriangular(rand(10,10))
julia> B*A #this works
julia> A*B
ERROR: MethodError: no method matching rmul!(::SparseMatrixCSC{Float64,Int64}, ::UpperTriangular{Float64,Array{Float64,2}})

Tests for this should also be added to LinearAlgebra/test/bidiag,jl around line 281. In that section, some sets of matrix types are evaluated but not in all orders so this method error doesn't show up.

I have two WIP PRs (#28343 #28345) to specialize the output types of these sorts of matrix multiplications but this should be fixed first. There are a few small bugs that pop up when doing special combinations of matrices and types (especially triangular and bigint/bigfloats).

@ArunS-tack
Copy link
Contributor

A*B works as well. This issue can be closed I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

No branches or pull requests

4 participants