Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractArrays in broadcast falls back to slow objectid when checking mightalias #28178

Open
KristofferC opened this issue Jul 19, 2018 · 2 comments
Open

AbstractArrays in broadcast falls back to slow objectid when checking mightalias #28178

KristofferC opened this issue Jul 19, 2018 · 2 comments
Labels
arrays [a, r, r, a, y, s] broadcast Applying a function over a collection performance Must go faster

Comments

@KristofferC
Copy link
Member

See the comment at #25890 (comment). and e.g. JuliaArrays/UnsafeArrays.jl#3.

mightalias is undocumented but yet it is sorely needed to overload in case one wants to have good performance when broadcasting with custom arrays.
Otherwise, a fallback objectid function is called which is slow.
@KristofferC KristofferC added performance Must go faster broadcast Applying a function over a collection labels Jul 19, 2018
@KristofferC
Copy link
Member Author

Ref #26237

@KristofferC KristofferC changed the title AbstractArrays in broadcast falls back to slow objectid when checkinig mightalias AbstractArrays in broadcast falls back to slow objectid when checking mightalias Aug 22, 2018
@maleadt maleadt mentioned this issue Sep 17, 2018
Closed
@mbauman mbauman mentioned this issue Aug 9, 2023
Open
@nsajko nsajko added the arrays [a, r, r, a, y, s] label May 5, 2024
@nsajko
Copy link
Contributor

nsajko commented May 5, 2024

xref #51753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s] broadcast Applying a function over a collection performance Must go faster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KristofferC @nsajko