Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move clipboard to InteractiveUtils #27635

Merged
merged 1 commit into from
Jun 19, 2018
Merged

move clipboard to InteractiveUtils #27635

merged 1 commit into from
Jun 19, 2018

Conversation

JeffBezanson
Copy link
Member

This seems like an odd thing to have in Base.

@JeffBezanson JeffBezanson added deprecation This change introduces or involves a deprecation excision Removal of code from Base or the repository stdlib Julia's standard library labels Jun 18, 2018
ararslan
ararslan approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'm surprised this didn't go when InteractiveUtils was initially separated. Unfortunate that our only test for the clipboard functionality is Windows-specific.

Needs a NEWS entry, but other than that LGTM.

@ararslan ararslan added the needs news A NEWS entry is required for this change label Jun 18, 2018
@JeffBezanson
Copy link
Member Author

I actually don't know why that test is restricted to windows. It works on my linux system FWIW.

@ararslan ararslan removed the needs news A NEWS entry is required for this change label Jun 18, 2018
@StefanKarpinski
Copy link
Member

Try removing the condition and see if the PR passes CI everywhere?

@JeffBezanson
Copy link
Member Author

Ah, of course. Linux CI doesn't have the necessary stuff installed. We can at least extend the test to mac os though.

@JeffBezanson JeffBezanson changed the title RFC: move clipboard to InteractiveUtils move clipboard to InteractiveUtils Jun 19, 2018
@JeffBezanson JeffBezanson merged commit 333ea8c into master Jun 19, 2018
@JeffBezanson JeffBezanson deleted the jb/clipboard branch June 19, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation excision Removal of code from Base or the repository stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeffBezanson @StefanKarpinski @ararslan