Added elementwise version of => to prec-pair #27447
Conversation
ararslan
added
parser
|
Thanks @MasonProtter, and welcome! I see you're working on porting scmutils to julia!? That's awesome. I took that class and this is something I've wanted for a while :) |
Thanks! I've been enamoured with julia for a little while now and am happy to start helping out, even if its a trivial little change here and there.
Yes! I haven't had any time for it in a while but I hope to get back on track soon! SICM is an awesome book and I'm hoping to learn a lot from porting scmutils. I'd like to eventually build a proper, julia native CAS with the lessons from scmutils. |
|
Are those failed builds likely problems with the CI tools or could there actually be a problem with such a minor change? |
|
You can go into the CI logs and see what made them fail and if it is relevant. CI is not rock solid right now. |
|
The test case from #27446 could be added to test/broadcast.jl. |
|
Looks like you've got whitespace issues. |
|
Trying to fix now. |
test/broadcast.jl
Outdated
| @@ -727,6 +727,13 @@ let f(args...) = *(args...) | |||
| @test f.(x..., f.(x..., y, z...), y, z...) == broadcast(f, x..., broadcast(f, x..., y, z...), y, z...) == 120*120 | |||
| end | |||
|
|
|||
| # Issue #27446: Broadcasting pair operator | |||
| let | |||
There was a problem hiding this comment.
Your trailing whitespace is on this line
|
It would be great if you could add a NEWS entry for this change as well. |
|
What section of NEWS.md would be appropriate for this? Language changes? |
|
I'd put it at the end of "new language features." |
NEWS.md
Outdated
| @@ -14,7 +14,28 @@ New language features | |||
| * Named tuples, with the syntax `(a=1, b=2)`. These behave very similarly to tuples, | |||
| except components can also be accessed by name using dot syntax `t.a` ([#22194]). | |||
|
|
|||
| * Keyword argument containers (`kw` in `f(; kw...)`) are now named tuples. Dictionary | |||
| * Keyw | |||
There was a problem hiding this comment.
Uh, I think something funky happened here.
There was a problem hiding this comment.
Yup, trying to fix now. Really sorry about spamming bad commits.
There was a problem hiding this comment.
No worries. Though you can view the diff yourself locally before pushing with git diff origin/master. That way you can spot oddities before they show up in the PR.
There was a problem hiding this comment.
You can also git checkout -- NEWS.md and start over with changes to that file, which may be easier.
There was a problem hiding this comment.
Thanks for the help. It appears to be fixed now. Hard to tell from the commit difs but if you look at https://github.com/JuliaLang/julia/pull/27447/files it looks kosher.
There was a problem hiding this comment.
Yep, looks good now. Nice work!
|
This is such a slick little syntax that just falls out of the existing rules so nicely 💃 |
|
I was a little skeptical of the |
#27446