Make UCP option the default for regex matching #27189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbauman
added
breaking
nalimilan
reviewed
May 21, 2018
base/regex.jl
Outdated
| @@ -72,8 +76,12 @@ after the ending quote, to change its behaviour: | |||
| - `s` allows the `.` modifier to match newlines. | |||
| - `x` enables "comment mode": whitespace is enabled except when escaped with `\\`, and `#` | |||
| is treated as starting a comment. | |||
| - `a` disables `UCP` mode (enables ASCII mode). By default `\\B`, `\\b`, `\\D`, `\\d`, `\\S`, | |||
| `\\s`, `\\W`, `\\w`, etc match based on unicode character properties. With this option, | |||
There was a problem hiding this comment.
"etc." and "Unicode". "are recognized" -> "these sequences only match"
\w matches numbers as well (which are not valid drive letters) and will match unicode characters once we turn on UCP.
Fixes #27084. Regexes now match based on unicode character properties, rather than just ASCII character properties, e.g. `match(r"\w+", "café")` will now match the entire word (and not just `caf`). This behavior can be disabled with the `a` flag to the regex string macro (e.g. `r"\w+"a`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27084. Regexes now match based on unicode character properties,
rather than just ASCII character properties, e.g.
match(r"\w+", "café")will now match the entire word (and not just
caf). This behavior canbe disabled with the
aflag to the regex string macro (e.g.r"\w+"a).