Provides Bidiagonal matrix type and specialized SVD #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides LAPACK.bdsqr! and LAPACK.bdsdc! wrappers Also fixes typo in tridiag
|
Can the name be BiDiagonal for consistency with TriDiagonal? The D in diagonal should be capitalized. Rest looks good. |
|
Also, let's update the svdvals and eigvals documentation to say what all special cases are available. |
|
Tridiagonal and SymTridiagonal do not have Diagonal capitalized, and Bidiagonal follows this scheme. Tri- and bidiagonal are both valid English words anyway. |
|
Oops. My bad. |
ViralBShah
pushed a commit
that referenced
this pull request
Mar 31, 2013
Provides Bidiagonal matrix type and specialized SVD
Closed
|
Just went looking for a bidagonal! Thanks so much guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides LAPACK.bdsqr! and LAPACK.bdsdc! wrappers
Also fixes typo in tridiag