Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2x regression in split() performance #26818

Closed
ghost opened this issue Apr 16, 2018 · 2 comments
Closed

2x regression in split() performance #26818

ghost opened this issue Apr 16, 2018 · 2 comments
Labels
performance Must go faster regression Regression in behavior compared to a previous version strings "Strings!"

Comments

@ghost
Copy link

ghost commented Apr 16, 2018 

using BenchmarkTools
@btime split("str,str,str,str,str,str,str", ",")

In v0.6:

 286.683 ns (10 allocations: 432 bytes)

In v0.7:

  567.859 ns (16 allocations: 624 bytes)
@nalimilan nalimilan added performance Must go faster regression Regression in behavior compared to a previous version strings "Strings!" and removed regression Regression in behavior compared to a previous version labels Apr 16, 2018
@ViralBShah
Copy link
Member

I get 650ns on 0.7-master and 426ns on 0.6.2.

@StefanKarpinski StefanKarpinski added this to the 1.0.x milestone May 25, 2018
This was referenced Oct 7, 2018
Closed
Closed
Merged
@KristofferC
Copy link
Member

These are almost the same now (270 ns vs 300 ns). Think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Must go faster regression Regression in behavior compared to a previous version strings "Strings!"
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StefanKarpinski @ViralBShah @nalimilan @KristofferC