Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmap Union of bits types #26309

Open
tpapp opened this issue Mar 3, 2018 · 2 comments
Open

mmap Union of bits types #26309

tpapp opened this issue Mar 3, 2018 · 2 comments

Comments

@tpapp
Copy link
Contributor

tpapp commented Mar 3, 2018

Now that arrays with Union of bitstypes elements have an optimized layout, it would be useful if one could mmap them. Alternatively, exporting the API that would allow the user to mmap the constituent flag and content vectors, then "assemble" the array, would also be as solution.

Cf

  1. a related issue on exporting the API: API for directly accessing the selector bytes of an isbits Union Array #24057
  2. discussion (I am opening this as a reminder, as suggested)
  3. I would use it in this package
@Keno
Copy link
Member

Keno commented Mar 3, 2018

The in memory representation of union bits types is not (and is not supposed to be) stable. However, you can achieve the same performance by an array view type of the appropriate element that uses the same logic (implemented in julia) and that'll keep working if we decide to change the representation.

@tpapp
Copy link
Contributor Author

tpapp commented Jul 30, 2018

Revisiting this issue, I am wondering if the representation has stabilized yet. It would be nice to mmap eg Vector{Union{Missing,Int}} and similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants