Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalization of DevNull #25786

Closed
yurivish opened this issue Jan 28, 2018 · 12 comments
Closed

Capitalization of DevNull #25786

yurivish opened this issue Jan 28, 2018 · 12 comments
Milestone

Comments

@yurivish
Copy link
Contributor

DevNull is proper case while STDOUT is upper case. Since we generally only use CamelCase for types and modules, this should perhaps be changed to something like DEVNULL.

(cc @nalimilan)

@yurivish
Copy link
Contributor Author

yurivish commented Feb 7, 2018

Bump. This is a small but backwards-incompatible name consistency change. Should it be done for 1.0?

@nalimilan nalimilan added the triage This should be discussed on a triage call label Feb 7, 2018
@nalimilan
Copy link
Member

Let's hear what triage thinks about this (will happen tomorrow).

@ararslan
Copy link
Member

ararslan commented Feb 8, 2018

I think we should do this.

@ararslan
Copy link
Member

ararslan commented Feb 8, 2018

As an aside, the Julia Vim definitions used to highlight DevNull as a type, likely because it's cased like it is one.

@JeffBezanson
Copy link
Member

From triage: there is some significant support for making these all lowercase --- stdout, stdin, stderr, devnull --- which follows C more. It also matches the keyword argument names to pipeline, e.g. pipeline(cmd, stderr=stdout).

@nalimilan
Copy link
Member

But don't we follow the convention that constants use uppercase?

@mbauman
Copy link
Member

mbauman commented Feb 8, 2018

It turns out neither STDOUT nor STDIN are constants. DevNull, however, is.

@ararslan
Copy link
Member

ararslan commented Feb 8, 2018

But don't we follow the convention that constants use uppercase?

It was pointed out that we don't always: Inf, NaN, missing, nothing, etc. (That said, I'm still in favor of this particular change.)

@JeffBezanson
Copy link
Member

I like lowercasing all of these: stdin, stdout, stderr, devnull. @Keno points out that devnull comes from /dev/null, which is lowercase.

@JeffBezanson JeffBezanson added this to the 1.0 milestone Feb 15, 2018
@JeffBezanson JeffBezanson removed the triage This should be discussed on a triage call label Feb 15, 2018
@StefanKarpinski
Copy link
Member

Also, stdin, stdout and stderr are all lowercase in C (upper casing then comes from Perl/Ruby).

@StefanKarpinski
Copy link
Member

Triage votes for lowercasing all of these with a dissenting vote from @ararslan.

@ararslan
Copy link
Member

I've adjusted #25959 per triage consensus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants