Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change RandomDevice(unlimited::Bool) to RandomDevice(; unlimited::Bool) #25668

Merged
merged 1 commit into from
Jan 22, 2018
Merged

change RandomDevice(unlimited::Bool) to RandomDevice(; unlimited::Bool) #25668

merged 1 commit into from
Jan 22, 2018

Conversation

rfourquet
Copy link
Member

@rfourquet rfourquet commented Jan 21, 2018 •
edited
Loading

Making unlimited a keyword argument is mainly for 2 reasons:

  1. it seems better that the argument(s) of an RNG constructor match those of srand (cf. srand docstring), i.e. that the positional argument(s) specify a seed.
  2. it is available only on non-Windows systems, and is not a functionality that is obviously expected, so it feels more "right" to name it (i.e. what RandomDevice(false) does is not guessable).

@rfourquet rfourquet added randomness Random number generation and the Random stdlib deprecation This change introduces or involves a deprecation labels Jan 21, 2018
@rfourquet rfourquet changed the title RandomDevice(unlimited::Bool) to RandomDevice(; unlimited::Bool) change RandomDevice(unlimited::Bool) to RandomDevice(; unlimited::Bool) Jan 21, 2018
@JeffBezanson JeffBezanson merged commit 4873dc0 into master Jan 22, 2018
@JeffBezanson JeffBezanson deleted the rf/rand/RD-unlimited-kw branch January 22, 2018 17:33
@cormullion cormullion mentioned this pull request Mar 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation randomness Random number generation and the Random stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfourquet @StefanKarpinski @JeffBezanson