Change findfirst and findlast to return cartesian indices with HasShape iterators #25655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2018
test/iterators.jl
Outdated
| @@ -321,7 +321,7 @@ end | |||
| @test Base.IteratorSize(product(1:2)) == Base.HasShape{1}() | |||
| @test Base.IteratorSize(product(1:2, 1:2)) == Base.HasShape{2}() | |||
| @test Base.IteratorSize(product(take(1:2, 1), take(1:2, 1))) == Base.HasShape{2}() | |||
| @test Base.IteratorSize(product(take(1:2, 2))) == Base.HasShape{2}() | |||
| @test Base.IteratorSize(product(take(1:2, 2))) == Base.HasShape{1}() | |||
There was a problem hiding this comment.
Should this change be moved to the first commit, or is it ok to just squash them?
There was a problem hiding this comment.
Ah, good catch. They could be squashed, but since the first one makes sense on its own, probably better keep them separate. I've moved the change to the first commit.
JeffBezanson
approved these changes
Jan 22, 2018
Needed to determine the shape of indices in a type-stable way.
…pe iterators
This represents better the shape of the iterator, and makes generators over
arrays consistent with their input array. Keep returning linear indices with
HasShape{1} iterators for consistency with vectors.
|
Should this have a NEWS entry because it breaks |
mbauman
added
breaking
|
See #25767. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This represents better the shape of the iterator, and makes generators over arrays consistent with their input array. Keep returning linear indices with
HasShape{1}iterators for consistency with vectors. See #10593. Part of #10593.The first commit is needed for this change, though it makes sense in isolation. It's extracted from #25356, where it received support from @timholy.