Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align readuntil and readline? #25633

Closed
JeffBezanson opened this issue Jan 18, 2018 · 0 comments
Closed

align readuntil and readline? #25633

JeffBezanson opened this issue Jan 18, 2018 · 0 comments
Assignees
Labels
deprecation This change introduces or involves a deprecation io Involving the I/O subsystem: libuv, read, write, etc.

Comments

@JeffBezanson
Copy link
Member

We changed readline to remove the trailing newline character by default, but readuntil still includes the delimiter. Arguably, they should behave the same.

readline also has a keyword argument chomp (defaulting to true) to control this. This is a slightly strange name, and is also very nearly a negative option (like saying "dont_include_delimiter=true"). This could be changed to keep, which would instead specify whether to keep the delimiter.

@JeffBezanson JeffBezanson added io Involving the I/O subsystem: libuv, read, write, etc. deprecation This change introduces or involves a deprecation labels Jan 18, 2018
@JeffBezanson JeffBezanson self-assigned this Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This change introduces or involves a deprecation io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Development

No branches or pull requests

1 participant