-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename module Random.dSFMT -> Random.DSFMT #25567
Conversation
Or perhaps drop the D? |
I also thought about that, but "DSFT" is also the name another (very related) lib, so this could be confusing. But I guess it doesn't really matter for this internal module, and I will update to |
If you drop the |
Maybe |
Ah right, I must have been quite tired 😊 |
If we want an initial capital, maybe LibdSFMT? |
SFMT is the name of the single precision version. But we don't need the D, since we could use dispatch. |
Coming to think of it, maybe just capitalize the D and move on. |
IIRC, SFMT produces natively 32 bits (and also 64?), i.e it's more directly suitable if you need to generate integers. But I don't think we will ever have SFMT wrapped in base/stdlib (I made tests a while ago, which didn't seem to give an advantage to SFMT compared to our current solution for producing integers). |
56fbdb6
to
0b55e0b
Compare
Added NEWS.md and |
I think this was the only module in base/stdlib not following the naming convention for capitalization. I think the "SFMT" part should remain upper-case as these are initials for "SIMD-oriented Fast Mersenne Twister" (the "d" in "dSFMT" is for "Double precision", which is in lower-case in http://www.math.sci.hiroshima-u.ac.jp/~m-mat/MT/SFMT/)