Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename module Random.dSFMT -> Random.DSFMT #25567

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Conversation

rfourquet
Copy link
Member

I think this was the only module in base/stdlib not following the naming convention for capitalization. I think the "SFMT" part should remain upper-case as these are initials for "SIMD-oriented Fast Mersenne Twister" (the "d" in "dSFMT" is for "Double precision", which is in lower-case in http://www.math.sci.hiroshima-u.ac.jp/~m-mat/MT/SFMT/)

@rfourquet rfourquet added the randomness Random number generation and the Random stdlib label Jan 15, 2018
@ViralBShah
Copy link
Member

Or perhaps drop the D?

@rfourquet
Copy link
Member Author

Or perhaps drop the D?

I also thought about that, but "DSFT" is also the name another (very related) lib, so this could be confusing. But I guess it doesn't really matter for this internal module, and I will update to DSFM if you prefer.

@StefanKarpinski
Copy link
Member

If you drop the D wouldn't that make the name SFMT?

@simonbyrne
Copy link
Contributor

Maybe @deprecate_binding?

@ararslan ararslan added the needs news A NEWS entry is required for this change label Jan 16, 2018
@rfourquet
Copy link
Member Author

If you drop the D wouldn't that make the name SFMT?

Ah right, I must have been quite tired 😊

@vtjnash
Copy link
Member

vtjnash commented Jan 17, 2018

If we want an initial capital, maybe LibdSFMT?

@ViralBShah
Copy link
Member

SFMT is the name of the single precision version. But we don't need the D, since we could use dispatch.

@ViralBShah
Copy link
Member

Coming to think of it, maybe just capitalize the D and move on.

@rfourquet
Copy link
Member Author

SFMT is the name of the single precision version

IIRC, SFMT produces natively 32 bits (and also 64?), i.e it's more directly suitable if you need to generate integers. But I don't think we will ever have SFMT wrapped in base/stdlib (I made tests a while ago, which didn't seem to give an advantage to SFMT compared to our current solution for producing integers).

@rfourquet rfourquet removed the needs news A NEWS entry is required for this change label Jan 17, 2018
@rfourquet
Copy link
Member Author

Added NEWS.md and @deprecate_binding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
randomness Random number generation and the Random stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants