Rename find() to findall() #25545
Merged
Rename find() to findall() #25545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
force-pushed
the
nl/findall
branch
3 times, most recently
from
42b7500
to
9d6465a
Compare
|
Looks like there's a doc reference issue. |
KristofferC
reviewed
Jan 15, 2018
NEWS.md
Outdated
| In particular, this means that it returns `CartesianIndex` objects for matrices | ||
| and higher-dimensional arrays instead of linear indices as was previously the case. | ||
| Use `LinearIndices(a)[find(f, a)]` to compute linear indices. | ||
| Use `LinearIndices(a)[findall(f, a)]` to compute linear indice |
There was a problem hiding this comment.
Accidentally cut off this sentence?
There was a problem hiding this comment.
Ah, thanks, that's an editor bug, it's not the first time I get this...
findall is more explicit and fits well in the series of findfirst/findlast and findnext/findprev.
|
Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findallis more explicit and fits well in the series offindfirst/findlastandfindnext/findprev. This change got some support at #10593.