Deprecate cumsum, cumprod, cumsum_kbn, and accumulate when dim isn't specified #24684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
deprecation
|
Rebase? |
nalimilan
reviewed
Nov 22, 2017
base/multidimensional.jl
Outdated
| @@ -691,7 +691,7 @@ function _cumsum!(out, v, axis, ::TypeArithmetic) | |||
| end | |||
|
|
|||
| """ | |||
| cumsum(A, dim=1) | |||
| cumsum(A, dim) | |||
There was a problem hiding this comment.
AFAICT there should be a separate docstring for AbstractVector, right? Also, ::Integer would be useful since there's no longer any indication of the expected type in the signature.
andreasnoack
force-pushed
the
anj/accumulate
branch
2 times, most recently
from
e8d02ea
to
5ff1bad
Compare
nalimilan
reviewed
Nov 22, 2017
base/multidimensional.jl
Outdated
| @@ -691,9 +691,9 @@ function _cumsum!(out, v, axis, ::TypeArithmetic) | |||
| end | |||
|
|
|||
| """ | |||
| cumsum(A, dim) | |||
| cumsum(A, axis::Integer) | |||
There was a problem hiding this comment.
I'd rather keep dim or use region, which are the two terms that appear to be common in similar functions.
There was a problem hiding this comment.
This is what the method uses. They used to be out of sync. However, since we have reducedim, it is probably better to use dim here as well. I'll update.
nalimilan
reviewed
Nov 22, 2017
base/multidimensional.jl
Outdated
|
|
||
| Cumulative operation `op` on `A` along the axis `axis`, storing the result in `B`. | ||
| Cumulative operation `op` on `A` along the dimensions `dim`, storing the result in `B`. |
andreasnoack
force-pushed
the
anj/accumulate
branch
from
473479a
to
92dfc4d
Compare
nalimilan
approved these changes
Nov 22, 2017
Should be fixed now. |
specified and dimension is larger than one
Fix bug in accumulate when initial value is provided since the implementation doesn't support multidimentional arrays. Move the accumulate methods with initial values to the end
andreasnoack
force-pushed
the
anj/accumulate
branch
from
92dfc4d
to
128f7c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and dimension is larger than one
Fixes #19451