Move suitesparse to stdlib #24648
Merged
Move suitesparse to stdlib #24648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViralBShah
force-pushed
the
vs/excisesuitesparse
branch
from
b65377a
to
6829505
Compare
ararslan
added
excision
base/precompile.jl
Outdated
| end | ||
| #if USE_GPL_LIBS | ||
| #precompile(Tuple{typeof(Base.SparseArrays.CHOLMOD.set_print_level), Array{UInt8, 1}, Int64}) | ||
| #end |
There was a problem hiding this comment.
This can just be deleted.
ViralBShah
force-pushed
the
vs/excisesuitesparse
branch
2 times, most recently
from
703ce57
to
e8a5775
Compare
ViralBShah
changed the title
ViralBShah
force-pushed
the
vs/excisesuitesparse
branch
from
e8a5775
to
f00d217
Compare
|
Should be good to merge if we get a green on CI. Rebased over the recent sparse changes. Would be nice to get it in before further sparse changes if possible. |
ViralBShah
changed the title
|
Need to add Line 221 in fb2ba43 |
Remove CHOLMOD stuff from precompile.jl Move unexported SparseArrays increment and decrement APIs to SuiteSparse Update SuiteSparse tests Add license text to new files.
ViralBShah
force-pushed
the
vs/excisesuitesparse
branch
from
f00d217
to
db601f4
Compare
|
Failing test was unrelated. |
|
Thanks for doing this, Viral! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #22698, move suitesparse to stdlib.
I can't quite figure out how to hook up the stdlib/SuiteSparse to base/sysimg.jl and the tests. Hence, if anyone can suggest what to do - I can do that, or commits on this branch appreciated.