Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process loads ~/.juliarc.jl for julia-base-cache target #24559

Closed
iamed2 opened this issue Nov 9, 2017 · 1 comment
Closed

Build process loads ~/.juliarc.jl for julia-base-cache target #24559

iamed2 opened this issue Nov 9, 2017 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior building Build system, or building Julia or its dependencies

Comments

@iamed2
Copy link
Contributor

iamed2 commented Nov 9, 2017

Introduced in #24120

Looks like some options should be set after JULIA_EXECUTABLE, at least --startup-file=no and maybe more?

@ararslan
Copy link
Member

ararslan commented Nov 9, 2017

Good catch. As a breadcrumb to someone who wants to fix this, it should be as easy as

--- a/Makefile
+++ b/Makefile
@@ -225,7 +225,7 @@ $(build_depsbindir)/stringreplace: $(JULIAHOME)/contrib/stringreplace.c | $(buil
        @$(call PRINT_CC, $(HOSTCC) -o $(build_depsbindir)/stringreplace $(JULIAHOME)/contrib/stringreplace.c)

 julia-base-cache: julia-sysimg-$(JULIA_BUILD_MODE) | $(DIRS) $(build_datarootdir)/julia
-       @$(call spawn,$(JULIA_EXECUTABLE) $(call cygpath_w,$(JULIAHOME)/etc/write_base_cache.jl) $(call cygpath_w,$(build_datarootdir)/julia/base.cache))
+       @$(call spawn,$(JULIA_EXECUTABLE) --startup-file=no $(call cygpath_w,$(JULIAHOME)/etc/write_base_cache.jl) $(call cygpath_w,$(build_datarootdir)/julia/base.cache))

 # public libraries, that are installed in $(prefix)/lib
 JL_LIBS := julia julia-debug

A test of some kind would be ideal but I'm not sure how best to do that.

@ararslan ararslan added bug Indicates an unexpected problem or unintended behavior building Build system, or building Julia or its dependencies labels Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior building Build system, or building Julia or its dependencies
Projects
None yet
Development

No branches or pull requests

2 participants