Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate rvalues consisting only of underscores #24221

Merged
merged 2 commits into from
Oct 20, 2017
Merged

deprecate rvalues consisting only of underscores #24221

merged 2 commits into from
Oct 20, 2017

Conversation

stevengj
Copy link
Member

Closes #22982.

@ararslan ararslan added the deprecation This change introduces or involves a deprecation label Oct 19, 2017
@stevengj
Copy link
Member Author

Looks like the usual unrelated OSX Travis failure.

@stevengj stevengj merged commit 4253e56 into JuliaLang:master Oct 20, 2017
@stevengj stevengj deleted the underscores branch October 20, 2017 22:35
@StefanKarpinski
Copy link
Member

Would it be better to deprecate both assignment to and use of multiple underscore names? Otherwise people might use __ in the same manner as _ and if we want to make it mean something else, that would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevengj @StefanKarpinski @JeffBezanson @ararslan