Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename realmin -> realabsmin? #23710

Closed
timholy opened this issue Sep 14, 2017 · 6 comments
Closed

Rename realmin -> realabsmin? #23710

timholy opened this issue Sep 14, 2017 · 6 comments

Comments

@timholy
Copy link
Sponsor Member

timholy commented Sep 14, 2017

Potentially confusing:

julia> typemax(Float32)
Inf32

julia> typemin(Float32)
-Inf32

julia> realmax(Float32)
3.4028235f38

julia> realmin(Float32)
1.1754944f-38
@timholy
Copy link
Sponsor Member Author

timholy commented Sep 14, 2017

Or maybe: typemax -> maxtype and realmax -> maxabsfinite

@pablosanjose
Copy link
Contributor

How about positivemax and positivemin?

@TotalVerb
Copy link
Contributor

It's also not the minimal representable positive value. I don't think there's a good term for this.

@TotalVerb
Copy link
Contributor

TotalVerb commented Sep 14, 2017

For typemax and typemin, I wonder if folding into maximum and minimum make any sense (thinking of the type as a set, of sorts).

For realmax and realmin, correct terms might be maxabsnormal and minabsnormal, or maxpositivenormal and minpositivenormal.

@alyst
Copy link
Contributor

alyst commented Sep 15, 2017

Another alternative:

  • realmax()/realmin() -> maxposnormal()/minposnormal() (to match with isposdef())

@oscardssmith
Copy link
Member

These are renamed and further renaming can't happen in 1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants