-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add typealiases for exact C-compatible types #2370
Conversation
Could we rename I'm not sure we need |
Nice! I think we should have |
It wasn't clear to me whether Cptrdiff_t or Cptrdiff was more correct. By analogy between Julia and C99 types, I dropped the |
I would just delete it, to be honest. The only real reason to have complex integers is for fixed-point arithmetic, as far as I can tell, but fixed-point complex arithmetic makes very little sense on any architecture with hardware multipliers. If Julia ever begins to target embedded systems, you could always add this later, or the programmer could just use |
would it make sense to add |
|
I agree with @stevengj about |
there's also the possibility of i imagined that you could reasonably have in your C code |
You have (on non-Windows):
Shouldn't this be |
add typealiases for exact C-compatible types
@stevengj Looks like Jeff patched it up after the merge. |
some more typealias's for consideration in the list that I forgot initially (in decreasing order of my interest level of actually having them added):
(travis build fails because I'm using OS_NAME before build_h.jl got included in the sysimg. I think it should be moved much earlier)