rename expression heads for type definitions to match keywords #23157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
breaking
|
I don't suppose there's any way to deprecate the old expression heads? I know a couple packages are using |
|
Yes, I can deprecate that particular use pattern. |
JeffBezanson
force-pushed
the
jb/typedefexprs
branch
from
5b56e13
to
acadf3a
Compare
|
Done. While I'm at it, I also changed the parsed representation to match the order that the subexpressions appear in the source. |
fredrikekre
reviewed
Aug 6, 2017
NEWS.md
Outdated
| @@ -35,6 +35,13 @@ Language changes | |||
| * Nested `if` expressions that arise from the keyword `elseif` now use `elseif` | |||
| as their expression head instead of `if` ([#21774]). | |||
|
|
|||
| * Parsed and lowered forms of type definitions have been synchronized with their | |||
| new keywords ([#23157]). Expression heads are renamed as follows: | |||
| `type` => `struct` | |||
There was a problem hiding this comment.
Perhaps add *s on this list with 4 space indent to render it as a bullet list? Current rendering looks a bit funny https://github.com/JuliaLang/julia/blob/acadf3acb6054adb657d6a9390616f2c1e792546/NEWS.md#language-changes
JeffBezanson
force-pushed
the
jb/typedefexprs
branch
from
acadf3a
to
6452535
Compare
ararslan
added
deprecation
martinholters
added a commit
to HSU-ANT/ACME.jl
that referenced
this pull request
Aug 29, 2017
...that automatically use the correct expression head to deal with JuliaLang/julia#23157.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.