Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate union() #23144

Merged
merged 1 commit into from
Aug 5, 2017
Merged

deprecate union() #23144

merged 1 commit into from
Aug 5, 2017

Conversation

JeffBezanson
Copy link
Member

This method dates from 2011, and we've generally moved away from having 0-arg methods of functions like this. It returns a Set{Any}, which would be better to discourage.

@JeffBezanson JeffBezanson added collections Data structures holding multiple items, e.g. sets deprecation This change introduces or involves a deprecation labels Aug 5, 2017
ararslan
ararslan approved these changes Aug 5, 2017
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I didn't even realize this was a thing

Sacha0
Sacha0 approved these changes Aug 5, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)

Worth a brief news entry?

@ararslan ararslan added the needs news A NEWS entry is required for this change label Aug 5, 2017
@JeffBezanson JeffBezanson merged commit c9a1844 into master Aug 5, 2017
@JeffBezanson JeffBezanson deleted the jb/emptyunion branch August 5, 2017 23:44
@tkelman tkelman removed the needs news A NEWS entry is required for this change label Aug 5, 2017
@cormullion cormullion mentioned this pull request Mar 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfourquet rfourquet rfourquet approved these changes

@ararslan ararslan ararslan approved these changes

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
collections Data structures holding multiple items, e.g. sets deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeffBezanson @Sacha0 @ararslan @rfourquet @tkelman