-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crush the vectorized method resistance #22961
Conversation
:acos, :acot, :acosd, :acotd, | ||
:cosh, :csch, :coth, :sech, | ||
:acsch, :asech] | ||
@eval @unarymap_z2nz $(op) Number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could also deprecate this macro? (or remove if not used outside of base)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, chances are most of the Xmap_YZ
macros/functions for SparseVector
s can be cleaned out with some care :). Would a separate pull request be alright?
Perhaps add a NEWS bullet and this should be good to go? |
Thanks for the bump! Added a commit with news for this pull request and updated news PR links. Best! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis is one timeout and Arnoldi.
Thanks all! :) |
This is truly a glorious moment. |
Wow, is this really the last of the vectorized methods? That is momentous. |
I suspect pockets of resistance remain, hopefully to be smoked out prior to The Great Feature Freeze. |
Hmm. I wonder if there's a way to automatically search for vectorized methods... |
Ok, I found some lingerers by the very high tech means of grepping for Lines 561 to 580 in 0f4229d
Issue opened: #23167. |
Fly the red flag and grant them no quarter.
Fixes #22959. Needs news? Best!