Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: deprecate showall #22847

Merged
merged 1 commit into from
Jul 18, 2017
Merged

RFC: deprecate showall #22847

merged 1 commit into from
Jul 18, 2017

Conversation

JeffBezanson
Copy link
Member

This function has become pretty useless, since showing everything is basically the default.

@JeffBezanson JeffBezanson added deprecation This change introduces or involves a deprecation display and printing Aesthetics and correctness of printed representations of objects. labels Jul 17, 2017
ararslan
ararslan approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KristofferC
Copy link
Member

I know BenchmarkTools uses this.

@ararslan
Copy link
Member

Does it have to?

@KristofferC
Copy link
Member

Probably not, I'm in favour of the deprecation but thought I would mention a place where it is actually used.

@TotalVerb
Copy link
Contributor

What happens with repr?

@JeffBezanson
Copy link
Member Author

The behavior of repr is the same, since the :limit property defaults to false, and repr calls show with a plain IOBuffer.

TotalVerb
TotalVerb approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@TotalVerb TotalVerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good then.

tkelman
tkelman reviewed Jul 18, 2017
View reviewed changes
NEWS.md Outdated
@@ -197,6 +197,9 @@ Deprecated or removed

* The method `String(io::IOBuffer)` is deprecated to `String(take!(copy(io)))` ([#21438]).

* The function `showall` is deprecated. Showing entire values is the default, unless an
`IOContext` specifying `:limit=>false` is in use ([#22847]).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless specifying :limit=>true ?

@JeffBezanson JeffBezanson merged commit f77d4cf into master Jul 18, 2017
@JeffBezanson JeffBezanson deleted the jb/showall branch July 18, 2017 17:03
@mauro3 mauro3 mentioned this pull request Jan 22, 2018
Open
@cormullion cormullion mentioned this pull request Mar 18, 2018
Closed
@nalimilan nalimilan mentioned this pull request Sep 18, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

@TotalVerb TotalVerb TotalVerb approved these changes

@ararslan ararslan ararslan approved these changes

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JeffBezanson @KristofferC @ararslan @TotalVerb @Sacha0 @tkelman