Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename AbstractIOBuffer => GenericIOBuffer (close #17360) #22796

Merged
merged 2 commits into from
Jul 14, 2017
Merged

rename AbstractIOBuffer => GenericIOBuffer (close #17360) #22796

merged 2 commits into from
Jul 14, 2017

Conversation

StefanKarpinski
Copy link
Member

Replaces #17360.

@tkelman
Copy link
Contributor

tkelman commented Jul 13, 2017

this should @deprecate_binding AbstractIOBuffer GenericIOBuffer false and be added to NEWS

@tkelman tkelman added deprecation This change introduces or involves a deprecation needs news A NEWS entry is required for this change labels Jul 13, 2017
Sacha0
Sacha0 approved these changes Jul 13, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)

@JeffBezanson JeffBezanson removed the needs news A NEWS entry is required for this change label Jul 14, 2017
@JeffBezanson JeffBezanson merged commit 9ea80a4 into master Jul 14, 2017
@tkelman tkelman deleted the sk/GenericIOBuffer branch July 14, 2017 04:25
@cormullion cormullion mentioned this pull request Mar 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StefanKarpinski @tkelman @Sacha0 @JeffBezanson