Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic fallback for logdet #22629

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Generic fallback for logdet #22629

merged 1 commit into from
Jul 7, 2017

Conversation

mschauer
Copy link
Contributor

@tkelman
Copy link
Contributor

tkelman commented Jun 30, 2017

maybe just for ::Number to be consistent with det? logabsdet might also be useful in some generic-code cases

@mschauer
Copy link
Contributor Author

mschauer commented Jun 30, 2017 •
edited
Loading

Hm.

Contra: if det is defined, logdet should be defined as well; if det is not defined, logdet fails with a (helpful) error that det is just not defined.

Pro: the presence of logdet somehow indicates, that it is "better" than just log(det(x))

@bramtayl
Copy link
Contributor

Is it possible to make a det method that specializes on log generators? Then you could get rid of logdet altogether

andreasnoack
andreasnoack approved these changes Jun 30, 2017
View reviewed changes
Copy link
Member

@andreasnoack andreasnoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to have for Any since it should always be correct and failing will happen as expected via det and log.

@kshyatt kshyatt added linear algebra Linear algebra maths Mathematical functions labels Jul 1, 2017
@mschauer
Copy link
Contributor Author

mschauer commented Jul 7, 2017

I think this is fine now.

@andreasnoack andreasnoack merged commit ad9f5de into JuliaLang:master Jul 7, 2017
@tkelman
Copy link
Contributor

tkelman commented Jul 7, 2017

should probably do logabsdet as well

@mschauer mschauer deleted the logdet branch July 18, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasnoack andreasnoack andreasnoack approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra maths Mathematical functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mschauer @tkelman @bramtayl @andreasnoack @kshyatt