Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually decouple special function (openspecfun) from base #22390

Closed
musm opened this issue Jun 16, 2017 · 7 comments · Fixed by #23598
Closed

Actually decouple special function (openspecfun) from base #22390

musm opened this issue Jun 16, 2017 · 7 comments · Fixed by #23598
Assignees
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries maths Mathematical functions
Milestone

Comments

@musm
Copy link
Contributor

musm commented Jun 16, 2017

SpecialFunctions relies on openspecfun from Base. Like FFTW would the next logical step be to have SpecialFunctions actually carry out the build process instead of in base

@ararslan
Copy link
Member

This is on my to-do list, we just need a pure Julia implementation of rem2pi. That's the only thing in Base that still uses openspecfun.

@ararslan ararslan added external dependencies Involves LLVM, OpenBLAS, or other linked libraries maths Mathematical functions labels Jun 16, 2017
@ararslan
Copy link
Member

Regarding a Julia implementation, ref discussion in #22004

@musm
Copy link
Contributor Author

musm commented Jul 8, 2017

BTW there is https://github.com/JuliaLang/openlibm/blob/1581174c85f7b645b15ba1ac1c3a98fb601f0fe7/src/e_rem_pio2.c

in openlibm which exactly the same as the openspecfun code .... but perhaps to call it some minor modification would need to be made to the C lib ? I'm not sure why we are calling the openspecfun version anyways

@ararslan
Copy link
Member

ararslan commented Jul 8, 2017

If I'm not mistaken, it's not standard to have that in system libms. Since we allow building with a libm other than openlibm but we don't allow any special function library other than openspecfun, we're likely calling it from openspecfun instead to ensure the function is always available.

@StefanKarpinski
Copy link
Member

This doesn't actually affect any Base APIs, does it? If so, it's a non-breaking change and can be removed from the 1.0 milestone.

@tkelman
Copy link
Contributor

tkelman commented Aug 31, 2017

Removing a library that people have been calling into and assuming gets shipped with julia binaries sounds breaking to me.

@ararslan
Copy link
Member

Yeah, it's definitely breaking for anyone who could be ccalling. This is a pretty easy removal anyway so I should have no trouble getting this out in the 1.0 timeframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries maths Mathematical functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants