Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the output of versioninfo() customizable with kwargs #21974

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Make the output of versioninfo() customizable with kwargs #21974

merged 1 commit into from
Jun 5, 2017

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented May 19, 2017 •
edited
Loading

also reordered some things in a more logical order. Fix #21971

What kwargs should we have?

@ararslan ararslan added the display and printing Aesthetics and correctness of printed representations of objects. label May 19, 2017
StefanKarpinski
StefanKarpinski reviewed May 20, 2017
View reviewed changes
base/interactiveutil.jl

println(io, "Environment:")
for (k,v) in ENV
if ismatch(r"JULIA", String(k))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we look for prefixes only? Include JL_-prefixed variables too? We've tried to move away from those, but there may be a few lingering here or there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply hoisted the printing of JULIA_* variables to always be displayed and the rest of the env vars for verbose=true. Add JL_ prefixed env vars to always show too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, don't bother – I grepped the source code and it seems like we don't have any lingering environment variables that start with JL_ anymore :)

@amitmurthy
Copy link
Contributor

As part of this PR, could we also print the Linux kernel version? Currently we just display OS: Linux (x86_64-linux-gnu). Will be good if it can display OS: Linux (x86_64-linux-gnu), Kernel xx.xx.xx

The uname system call appears to provide this information - https://linux.die.net/man/2/uname

@fredrikekre
Copy link
Member Author

Output of uname is included already. Do you propose to display it as default (it's currently only shown with verbose=true)?

@amitmurthy
Copy link
Contributor

That is fine then. I was not aware of the verbose option.

@fredrikekre
Copy link
Member Author

Rebased. I am happy with the PR as is. It is easy to add more kwargs later if need be.

@fredrikekre fredrikekre changed the title [WIP] Make the output of versioninfo() customizable with kwargs Make the output of versioninfo() customizable with kwargs May 25, 2017
@fredrikekre
Copy link
Member Author

Rebased.

@KristofferC KristofferC merged commit 9f61fda into JuliaLang:master Jun 5, 2017
@fredrikekre fredrikekre deleted the fe/versioninfo branch June 5, 2017 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fredrikekre @amitmurthy @StefanKarpinski @KristofferC @ararslan