Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make write/unsafe_write on iobuffer return signed like other io #20609

Merged
merged 3 commits into from
Feb 19, 2017

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Feb 14, 2017

Noticed by @tkelman in #20608 (comment).

Before:

julia> io = IOBuffer()
IOBuffer(data=UInt8[...], readable=true, writable=true, seekable=true, append=false, size=0, maxsize=Inf, ptr=1, mark=-1)

julia> write(io, "SGVsbG8h")
0x0000000000000008

julia> write(Base64EncodePipe(io), "SGVsbG8h")
8

julia> write(open("bla", "w"), "SGVsbG8h")
8

@ararslan ararslan added the io Involving the I/O subsystem: libuv, read, write, etc. label Feb 14, 2017
@tkelman
Copy link
Contributor

tkelman commented Feb 15, 2017

I wonder what this might break, but I think we usually go for signed ints in most API's like this. x-ref 2af73dd (and the fixup 7535258) where changing it the other way around broke a whole bunch of things

@KristofferC
Copy link
Member Author

Is this breaking and should thus have a NEWS entry?

@StefanKarpinski StefanKarpinski added the needs news A NEWS entry is required for this change label Feb 15, 2017
@KristofferC KristofferC merged commit 36569d6 into master Feb 19, 2017
@KristofferC KristofferC deleted the kc/iobuffer_ret branch February 19, 2017 17:05
@Sacha0 Sacha0 removed the needs news A NEWS entry is required for this change label May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants